Open
Conversation
- addSimplePointLayer - addNodeToLayer - getLayer - findGeometriesWithinDistance - findGeometriesInBBox
Added: - addSimplePointLayer - addNodeToLayer - getLayer - findGeometriesWithinDistance - findGeometriesInBBox First working version, not fully unit tested but tested functionality and works
Author
There was a problem hiding this comment.
Hey @Kwattro sorry I have been away for 2 weeks so just seeing this now. Anything I changed was because I was branching off of this project as after speaking to @jadell he didn't have time to review and advised I just forked and continued using my fork, so I am for now as I am actively using this library in one of my own projects.
If we do get some people to review my changes of course I will go through all changes with them and happy to change everything back.
|
Any update? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated compser.json and fixed unit test