Open
Conversation
Contributor
Author
|
@jadell I added a simple DI class which may solve the problems with the configurations. The idea is to keep there configuration variables and things such as closures for creating nodes/relationships...etc. I also added a bootstrap file with some initial dependencies to be populated in the DI (Bootstrap.php). Putting more object initialization callbacks in the DI will also allow easier extension of the library. |
Owner
|
I like where this is going, but I'd like to make a few changes. It's similar to the "Configuration" class I was thinking of introducing. I'm going to merge this into a branch and tweak it a bit, if that's okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add options to the transport for ssl request.
Example:
$transport = new Transport\Curl("127.0.0.1", "443");
$sslOptions = array(CURLOPT_SSL_VERIFYPEER => true, CURLOPT_SSLCERT => "/path/to/cert");
$transport->useHttps(true, $sslOptions);
OR
$transport = new Transport\Stream("127.0.0.1", 443);
$sslOptions = array("verify_peer" => false, "cafile" => "path/to/cafile);
$transport->useHttps(true, $sslOptions);
Also when sending request through ssl with context_stream the stream_options array must be with key http for the http options and the ssl specific option must be with key ssl.