Skip to content

Comments

Remove auth dependency#2

Open
kleberbaum wants to merge 2 commits intomainfrom
mk9mvf-netsnek/fix-crypto.createsign-in-cloudflare-worker
Open

Remove auth dependency#2
kleberbaum wants to merge 2 commits intomainfrom
mk9mvf-netsnek/fix-crypto.createsign-in-cloudflare-worker

Conversation

@kleberbaum
Copy link
Member

Summary

  • drop auth usage to avoid crypto.createSign
  • patch pylon to avoid crypto.createSign

Testing

  • npm run build (fails: Cannot find type definition file for 'bun-types')
  • npm test (fails: vitest not found)

Codex couldn't run certain commands due to environment limitations. Consider configuring a setup script or internet access in your Codex environment to install dependencies.


https://chatgpt.com/codex/tasks/task_e_6860245c2490832d86639962e35b1ba3

@kleberbaum kleberbaum self-assigned this Jun 28, 2025
@kleberbaum kleberbaum requested a review from Copilot June 28, 2025 18:06

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kleberbaum kleberbaum requested a review from Copilot June 28, 2025 18:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the usage of auth dependency by eliminating crypto.createSign and replacing it with a WebCrypto-based implementation, as well as patching pylon accordingly.

  • Updated node_modules/@getcronit/pylon/auth.js to use WebCrypto instead of crypto.createSign.
  • Added a postinstall script and patch-package dependency in package.json to ensure patch application.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
patches/@getcronit+pylon+2.0.0.patch Replaces crypto.createSign with WebCrypto functions
package.json Adds postinstall script for patch-package and new dependency
Comments suppressed due to low confidence (1)

patches/@getcronit+pylon+2.0.0.patch:10

  • Ensure that the function containing these asynchronous operations is declared as async; otherwise, the use of await will result in a syntax error.
+  const key = await crypto.subtle.importKey(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant