Open
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the usage of auth dependency by eliminating crypto.createSign and replacing it with a WebCrypto-based implementation, as well as patching pylon accordingly.
- Updated node_modules/@getcronit/pylon/auth.js to use WebCrypto instead of crypto.createSign.
- Added a postinstall script and patch-package dependency in package.json to ensure patch application.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| patches/@getcronit+pylon+2.0.0.patch | Replaces crypto.createSign with WebCrypto functions |
| package.json | Adds postinstall script for patch-package and new dependency |
Comments suppressed due to low confidence (1)
patches/@getcronit+pylon+2.0.0.patch:10
- Ensure that the function containing these asynchronous operations is declared as async; otherwise, the use of await will result in a syntax error.
+ const key = await crypto.subtle.importKey(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authusage to avoid crypto.createSignTesting
npm run build(fails: Cannot find type definition file for 'bun-types')npm test(fails: vitest not found)Codex couldn't run certain commands due to environment limitations. Consider configuring a setup script or internet access in your Codex environment to install dependencies.
https://chatgpt.com/codex/tasks/task_e_6860245c2490832d86639962e35b1ba3