Conversation
|
@pcwinters, sorry about the delayed response. This looks pretty neat. I like the idea of splitting the automatic namespacer out, as it does feel like a separate concern to generating the Pacomo names themselves. Given the automatic namespacer is separated out, I feel like it probably should be placed in a separate package, with just the strategy left in react-pacomo. But before worrying about that - I'm not a huge fan of using ES6 classes to store what are effectively constants. If you could find a way to express the strategy as a function (probably returning an object containing other functions), I'd be happy to try and merge this with a view to eventually splitting the prefixing code out into a separate package. |
|
@jamesknelson, tell me if this suits. The automatic namespacer is tremendously useful, and I'd love to see a separate package with a well thought out API. This is admittedly a bit of a rough-in. |
@jamesknelson, wondering if you see value in providing this as an automatic namespacer decoupled from the pacomo naming strategy. I do!