Skip to content

Fix method name typo and import issues across model files#5

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/find-codebase-errors
Draft

Fix method name typo and import issues across model files#5
Copilot wants to merge 2 commits intomainfrom
copilot/find-codebase-errors

Conversation

Copy link

Copilot AI commented Feb 2, 2026

Overview

Found and fixed critical errors preventing model instantiation: typo in validation method name and import inconsistencies.

Changes

  • Fixed method name typo across all models (20 occurrences): timestep_validatatetimestep_validate

    • models/CGLE.py (4 occurrences)
    • models/NS.py (5 occurrences)
    • models/QG.py (4 occurrences)
    • models/S_MHD.py (4 occurrences)
    • models/ETD_KT_CM_JAX_Vectorised.py (3 occurrences)
  • Removed duplicate import os statement in models/CGLE.py

  • Changed to relative import in filters/__init__.py: from filters.resamplingfrom .resampling

Impact

Without this fix, all model classes would raise AttributeError on instantiation:

# Before: crashes with AttributeError: 'CGLE_SETD_KT_CM_JAX' object has no attribute 'timestep_validatate'
model = CGLE_SETD_KT_CM_JAX(params)

# After: works correctly
model = CGLE_SETD_KT_CM_JAX(params)  # Calls timestep_validate() successfully

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: jameswoodfield <34720593+jameswoodfield@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix errors in codebase Fix method name typo and import issues across model files Feb 2, 2026
Copilot AI requested a review from jameswoodfield February 2, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants