Default to X11 as GLFW_PLATFORM on Linux to avoid issues#74
Merged
Conversation
Wayland/libdecor ASAN leak which causes unresponsiveness. See issue #68 #68 Summary: ASAN reports leaks seemingly from the Wayland decoration stack (libdecor/GTK/Pango/Fontconfig via GLFW) that persist until process exit. This does not seem to be related to render/present stalls; override with GLFW_PLATFORM if you explicitly want Wayland. Maybe it can work with Wayland at some point
jamylak
changed the title
X11 as GLFW_PLATFORM on Linux to avoidX11 as GLFW_PLATFORM on Linux to avoid issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default to
X11asGLFW_PLATFORMon Linux to avoidWaylandrelatedASANleak which causes unresponsiveness. See issue #68Summary:
ASANreports leaks seemingly from theWaylanddecoration stack (libdecor/GTK/Pango/FontconfigviaGLFW) that persist until process exit.This does not seem to be related to render/present stalls; override with
GLFW_PLATFORMif you explicitly wantWayland.Maybe it can work with
Waylandat some pointWorkaround for #68 by using
X11instead ofWaylandthough it would be good to support WaylandAlso similar to #73 this will update the release workflow to use the update name of the vulkan ICD JSON file