Add exception to throw when meta tag is not a Map#145
Open
ianrumac wants to merge 1 commit intojasminb:developfrom
Open
Add exception to throw when meta tag is not a Map#145ianrumac wants to merge 1 commit intojasminb:developfrom
ianrumac wants to merge 1 commit intojasminb:developfrom
Conversation
Adds a InvalidMetaDataTypeException to be thrown when the meta data tag is not a map instead of catching the exception and returning null and adds a testInvalidMetaData test to cover it.
Author
|
Lost a few hours looking at what's wrong since the method just catched the exception and returned null, turns out the outer meta object was an array so the parsing was failing. Just added an exception that explains it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a InvalidMetaDataTypeException to be thrown when the meta
data tag is not a map instead of catching the exception and
returning null and adds a testInvalidMetaData test to cover it.