Update socket2 Rust dependency to fix Windows build#25
Open
talklittle wants to merge 2 commits intojayjun:masterfrom
Open
Update socket2 Rust dependency to fix Windows build#25talklittle wants to merge 2 commits intojayjun:masterfrom
talklittle wants to merge 2 commits intojayjun:masterfrom
Conversation
Author
|
Updated. Adding explicit dependency wasn't needed; instead use |
19ccaaa to
1b45916
Compare
|
I can confirm this builds fine on Windows with the latest version of Rust(1.81.0) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows compile by updating the
socket2Rust dependency to 0.3.19.Fixes #21
Reproduce the error by running docker:
Results in this Rust error:
After adding a dependency on socket2 version 0.3.19 in Cargo.toml, and rebuilding the Docker image, the Rambo compilation succeeds.
Relevant socket2 issue: rust-lang/socket2#119 fixed in v0.3.16