[DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine#295
Open
iankko wants to merge 1 commit intojboss-openshift:masterfrom
Open
[DO NOT MERGE][CLOUD-2453][KEYCLOAK-7098] Add wait_for_service launch script routine#295iankko wants to merge 1 commit intojboss-openshift:masterfrom
iankko wants to merge 1 commit intojboss-openshift:masterfrom
Conversation
Contributor
Author
7 tasks
169e7fd to
888ae59
Compare
Crumby
reviewed
Sep 21, 2018
0884814 to
b478077
Compare
13d60e0 to
77b3957
Compare
Describe and add example values for the newly introduced SERVICE_WAIT_NAME, SERVICE_WAIT_RETRY_MESSAGE, and SERVICE_WAIT_INTRO_MESSAGE environment variables Also move the description of SSO_ADMIN_USERNAME, SSO_ADMIN_PASSWORD, SSO_SERVICE_USERNAME, and SSO_SERVICE_PASSWORD variables from image.yaml to os-sso/module.yaml. These variables aren't used / referenced outside of some of os-sso, os-sso71, and os-sso72 modules, and for the future we want one common 'os-sso' module, sharing all the parts common to all RH-SSO images. This move is part of such unification Signed-off-by: Jan Lieskovsky <jlieskov@redhat.com>
166e783 to
6c8e0b5
Compare
Contributor
Author
|
The PR was updated, and should be ready for re-review. |
rcernich
approved these changes
Oct 10, 2018
Contributor
rcernich
left a comment
There was a problem hiding this comment.
I'm okay with these, but I have to say again that the paradigm is to let the pod cycle until the db becomes available (i.e. this isn't very cloudy, maybe it's sunshiny;)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jan Lieskovsky jlieskov@redhat.com
Thanks for submitting your Pull Request!
Please make sure your PR meets following requirements:
[CLOUD-XYA] SubjectCONTRIBUTING.md)Signed-off-by: Your Name <yourname@redhat.com>- usegit commit -s