Open
Conversation
Owner
|
@Thalhammer Neat idea. I'm so sorry it's been three years since you opened this PR -- before I start taking a closer look, is this something you'd still find useful? |
Owner
|
(milestone tentative; waiting on author) |
Author
|
Ofc I think its still usefull. In fact I use it everyday in production. |
Owner
|
Great! I want to think about this use case a bit more, and see if I can make your client code even easier with a more invasive change. Definitely a 0.2.x sort of thing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm currently developing an apache plugin (mod_grpcbackend) that allows a grpc server to provide an HTTP interface without needing to implement a server itself.
I was in the process of adding WebSocket support when I came across this plugin.
The changes I made to this plugin are quite minor but IMHO can be quite helpful for apache plugin writers.
I added a hook which gets called if WebSocketHandler is set to "internal" and there is no dso with this name.
Other plugins can hook into this and check if they are expected to handle it using the provided name.
If so they set the plugin pointer and from there everything is the same as normal.