Skip to content

Ensure before_sleep_log message isn't multiline #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sebastian-correa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ensure before_sleep_log message isn't multiline #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions releasenotes/notes/multline-error-log-fix-f4791dd41c9915a3.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
fixes:
- |
Strip the ``str`` representation of the exception to avoid multiline
log output from ``before_sleep()`` when some exceptions include ``\n``
characters at the end of their string representation.
3 changes: 2 additions & 1 deletion tenacity/before_sleep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ def log_it(retry_state: "RetryCallState") -> None:

if retry_state.outcome.failed:
ex = retry_state.outcome.exception()
verb, value = "raised", f"{ex.__class__.__name__}: {ex}"
exception_str = str(ex).strip() # Ensure message isn't multiline.
verb, value = "raised", f"{ex.__class__.__name__}: {exception_str}"

if exc_info:
local_exc_info = retry_state.outcome.exception()
Expand Down