Skip to content

Fix retry_if_exception_message rejecting empty string arguments #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bysiber wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Fix retry_if_exception_message rejecting empty string arguments #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tenacity/retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,19 +198,19 @@ def __init__(
message: str | None = None,
match: None | str | re.Pattern[str] = None,
) -> None:
if message and match:
if message is not None and match is not None:
raise TypeError(
f"{self.__class__.__name__}() takes either 'message' or 'match', not both"
)

# set predicate
if message:
if message is not None:

def message_fnc(exception: BaseException) -> bool:
return message == str(exception)

predicate = message_fnc
elif match:
elif match is not None:
prog = re.compile(match)

def match_fnc(exception: BaseException) -> bool:
Expand Down
Loading