fix: restore plain function composition with retry_base via | and ɞ
Merged
mergify[bot] merged 1 commit intomainfrom Feb 24, 2026
Conversation
The delegation to __ror__/__rand__ introduced for async retry support broke composing retry_base instances with plain callables. Add an isinstance guard so delegation only happens for retry_base subclasses, while plain callables fall through to direct retry_all/retry_any wrapping. Also widen type annotations on retry_any/retry_all and the operator methods to accept RetryBaseT (the union of retry_base and plain callables), matching the runtime behavior. Fixes #481 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: I24e081b67dfa7e184266621f73cec4de5177ea25
mergify
bot
deleted the
devs/jd/fix/retry-base-compose-plain-functions/I24e081b67dfa7e184266621f73cec4de5177ea25
branch
Contributor
Merge Queue StatusRule:
This pull request spent 7 seconds in the queue, with no time running CI. Required conditions to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delegation to ror/rand introduced for async retry support
broke composing retry_base instances with plain callables. Add an
isinstance guard so delegation only happens for retry_base subclasses,
while plain callables fall through to direct retry_all/retry_any wrapping.
Also widen type annotations on retry_any/retry_all and the operator
methods to accept RetryBaseT (the union of retry_base and plain
callables), matching the runtime behavior.
Fixes #481
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com