fix: sync func.retry.statistics with copy's statistics#614
Merged
mergify[bot] merged 1 commit intomainfrom Feb 25, 2026
Conversation
jd
force-pushed
the
devs/jd/fix/retry-statistics-sync/I0299c76659ae6fc0c6354efae22b17946dca223c
branch
from
832c658 to
bba759c
Compare
Fixes #613 func.retry.statistics was always empty because func.retry points to the original Retrying object, but begin() (which populates statistics) is only called on the per-invocation copy. Fix by pointing the original's _local.statistics to the copy's statistics dict so they share the same object. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Change-Id: I0299c76659ae6fc0c6354efae22b17946dca223c
jd
force-pushed
the
devs/jd/fix/retry-statistics-sync/I0299c76659ae6fc0c6354efae22b17946dca223c
branch
from
bba759c to
36a0f60
Compare
mergify
bot
deleted the
devs/jd/fix/retry-statistics-sync/I0299c76659ae6fc0c6354efae22b17946dca223c
branch
Contributor
Merge Queue StatusRule:
This pull request spent 11 seconds in the queue, including 1 second running CI. Required conditions to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #613
func.retry.statistics was always empty because func.retry points to
the original Retrying object, but begin() (which populates statistics)
is only called on the per-invocation copy. Fix by pointing the
original's _local.statistics to the copy's statistics dict so they
share the same object.
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com