Fixed Player moving faster diagonal#2
Open
user84918342 wants to merge 1 commit intojdah:masterfrom
user84918342:patch-1
Open
Fixed Player moving faster diagonal#2user84918342 wants to merge 1 commit intojdah:masterfrom user84918342:patch-1
user84918342 wants to merge 1 commit intojdah:masterfrom
user84918342:patch-1
Conversation
First of all. I love this project and I think I am going to do some PRs in the future. Now to my PR. I am not really sure if this is intentional but I think it doesn`t make sense to let the player move faster diagonal. So I did this quick fix. Could you please message me on Discord? My username is Lasnik#0294. I have some questions :D
|
lol i was just gonna say xD |
maxdbarton97
approved these changes
Feb 18, 2021
|
This change currently causes the player character to not be able to move diagonally at all rather than fixing the player's speed. |
Well, RIP any chance of this PR getting fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not really sure if this is intentional but I think it doesn`t make sense to let the player move faster diagonal. So I did this quick fix.