Skip to content

feat: Remove non-matrix mode, always generate single validate job#137

Merged
jdutton merged 3 commits intomainfrom
remove-non-matrix-mode
Feb 26, 2026
Merged

feat: Remove non-matrix mode, always generate single validate job#137
jdutton merged 3 commits intomainfrom
remove-non-matrix-mode

Conversation

@jdutton
Copy link
Owner

@jdutton jdutton commented Feb 26, 2026

Summary

  • Removes non-matrix CI workflow generation mode entirely — generate-workflow now always produces a single validate job with matrix strategy
  • This matches the local pnpm validate experience: all steps run sequentially in one runner, so setup steps (e.g., npx playwright install) execute before tests
  • Eliminates the useMatrix option, getAllJobIds(), createCommonJobSetupSteps(), and addCoverageReportingSteps() (-434 lines net)
  • Projects previously using non-matrix mode will see doctor report workflow out-of-sync and can regenerate with npx vibe-validate generate-workflow

Test plan

  • All 43 generate-workflow tests pass (removed 17 non-matrix tests, updated remaining)
  • Full pnpm validate passes (build, typecheck, lint, duplication, unit tests, integration tests)
  • CLI reference docs regenerated and in sync
  • Version bumped to v0.19.0-rc.13

🤖 Generated with Claude Code

jdutton and others added 2 commits February 26, 2026 07:03
CI workflows now always generate a single "validate" job that runs all
validation steps sequentially - matching the local `pnpm validate`
experience. This ensures setup steps (e.g., playwright install) run
before tests, and new checkouts for developers and CI just work.

Removes useMatrix option, getAllJobIds(), createCommonJobSetupSteps(),
and addCoverageReportingSteps() (-434 lines net).

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 96.80851% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.72%. Comparing base (8ef62e2) to head (822ce8a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/commands/generate-workflow.ts 96.80% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   85.79%   85.72%   -0.08%     
==========================================
  Files         115      115              
  Lines       15068    14903     -165     
  Branches     3245     3215      -30     
==========================================
- Hits        12928    12775     -153     
+ Misses       2140     2128      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude <noreply@anthropic.com>
@sonarqubecloud
Copy link

@jdutton jdutton merged commit 5ed511a into main Feb 26, 2026
7 checks passed
@jdutton jdutton deleted the remove-non-matrix-mode branch February 26, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant