Add RequiresUnreferencedCode attribute for reflection code and add OverloadResolutionPriority attribute to prefer non-object methods#50
Merged
jeffijoe merged 3 commits intojeffijoe:masterfrom Mar 3, 2025
Conversation
jeffijoe
approved these changes
Mar 3, 2025
Owner
|
Thanks! Released to NuGet as 7.1.3 👍 Unrelated, but I remember you from the Xamarin forums in the early days of Xamarin, back when I started learning C#, so it was funny to see @Cheesebaron aka Ostebaronen in my inbox again after all these years. 😄 |
Contributor
Author
Sweet! Thanks!
Ah, that is cool! The world is small :) |
Owner
Yeah, even more so because I'm also Danish 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
RequiresUnreferencedCodeattribute on methods that use reflection. This is primarily the convenience methods and extension methods that take anobjectlike:new { hello = "world" }and turns it into a dictionary with keyhellowhich will be equal to the string object"world".Also added the
IsTrimmable=trueproperty on the project, which allows the compiler to trim the library.For the extension methods that take the
objectas argument, I've also added the[OverloadResolutionPriority(-1)]attribute to make the compiler prefer the nonobjectoverloads.Fixes #49