WIP: Update dependencies, tests #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since elixir 1.6 is no longer receiving security updates, remove it from the test matrix and add the latest version (1.13).
In order to support recent elixir versions, update dialyxir dependency version.
In order to resolve a warning, make process_response/1 public.
Use the newer `extra_applications` param to take advantage of elixir's automated application detection.
Remove the deprecated halt-exit-status flag, as this is now the default.
Remove typespecs for process_headers / process_response, since those are provided by HTTPoison.
Author
|
After doing lots of library version updates, I got into the dialyzer failures and realized that they probably existed in master. In an effort to address those separately, I opened https://github.com/fastjames/forcex/tree/elixir_18_updates and worked solely on dialyzer-related changes there. That branch now runs |
Author
|
Opened PR: #54 |
Author
|
Closing in favor of #54 and its followup for 1.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make this library usable with modern elixir applications, update dependencies and the test matrix to work with the latest version of elixir.