Skip to content

[JENKINS-26318] Migrate to svnkit 1.8#1

Open
christ66 wants to merge 4 commits intojenkinsci:masterfrom
christ66:svnkit18
Open

[JENKINS-26318] Migrate to svnkit 1.8#1
christ66 wants to merge 4 commits intojenkinsci:masterfrom
christ66:svnkit18

Conversation

@christ66
Copy link
Member

This pull request does two things:

  • Migrate to use the default svnkit library.
  • Use the latest svnkit 1.8 library.

This will make the BlameSubversion-plugin compatible with the latest subversion plugin, and fix JENKINS-26318

@reviewbybees

@christ66 christ66 changed the title WIP Migrate to svnkit 1.8 [JENKINS-26318] Migrate to svnkit 1.8 Oct 25, 2015
@ghost
Copy link

ghost commented Oct 25, 2015

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be better to name this something else so as not to cause confusion between it and org.tmatesoft.svn.core.auth.ISVNAuthenticationManager?

@tfennelly
Copy link
Member

🐝

But two things:

  1. In general, I would not be a big fan of knowingly creating classes with the same names as existing classes (SVNSSLAuthentication etc in this case).
  2. I'd say others would not like the fact that new code was added below the hudson package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants