[FIXED JENKINS-34968] Domain in login is not taken into account

[fbelzunc]

If we write subdomain in the login, then this subdomain is not taken into account.

This is related to changes by this commit: 7c04f78

This is incorrect:
If people type in 'foo@bar' or 'bar\foo' or just 'foo', it should be treated as 'foo@bar' (where 'bar' represents the given domain name)

'bar' is represent a domain name which is set in the configuration, not in the login.

For example we set our Domain Name to 'bar.com'. Then we write login 'subbar\foo'. We expect to transform this to 'foo@subbar.bar.com'. But instead a 'foo@bar.com' is used.

https://issues.jenkins-ci.org/browse/JENKINS-34968

@reviewbybees @jtnord

[jtnord]

For example we set our Domain Name to 'bar.com'. Then we write login 'subbar\foo'. We expect to transform this to 'foo@subbar.bar.com'. But instead a 'foo@bar.com' is used.

That expectation is wrong to me... if you are providing the NT legacy domain then DOMAIN\User then some magic should probably happen on that NT domain,. Note the NT DOMAIN is not gauranteed to be DOMAIN.something.other - it may not even be in the actual domain (e.g. domain UKBLAH can map to uk.blah.com) If you provide a domain in the form foo@bar then bar is the domain name and should be used - no further processing of the domain in this case should be performed (that is foo@whatever is the principal name and is already fully qualified - if not its not valid)

[ghost]

This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation.