Replace docker-fixtures with testcontainers#15
Open
strangelookingnerd wants to merge 2 commits intojenkinsci:masterfrom
Open
Replace docker-fixtures with testcontainers#15strangelookingnerd wants to merge 2 commits intojenkinsci:masterfrom
docker-fixtures with testcontainers#15strangelookingnerd wants to merge 2 commits intojenkinsci:masterfrom
Conversation
basil
requested changes
Jul 11, 2025
Member
There was a problem hiding this comment.
This PR is introduced technical debt, as the Dockerfile is duplicated between jenkinsci/workflow-api-plugin#414 and jenkinsci/docker-fixtures#122, which creates a maintenance burden. See this page for more information about why this is the case. I recommend refactoring the common images that used to be present in docker-fixtures into a new Jenkins repository for TestContainers, something like https://github.com/dasniko/testcontainers-keycloak.
Contributor
|
(Note: Windows agents are not allocated due to deprecated label. Please see #16 for a fix) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
docker-fixtureswithtestcontainers(see jenkinsci/docker-fixtures#122 (comment))Testing done
mvn clean verfiyhad failing tests withNo such command: dist-forkon my machine.Submitter checklist