Closed
Conversation
vikrantsnirban
commented
Mar 3, 2022
vikrantsnirban
commented
- Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
- Ensure that the pull request title represents the desired changelog entry
- Please describe what you did - To add JNLP support to Plugin
- Link to relevant issues in GitHub or Jira - https://github.com/vikrantsnirban/google-compute-engine-plugin
- Link to relevant pull requests, esp. upstream and downstream changes
- Ensure you have provided tests - that demonstrates feature works or fixes the issue
jglick
reviewed
Mar 28, 2024
.../resources/com/google/jenkins/plugins/computeengine/ComputeEngineCloud/help-jnlpSupport.html
Outdated
Show resolved
Hide resolved
jglick
reviewed
Jul 10, 2025
Member
There was a problem hiding this comment.
Changes to this file do not belong here.
jglick
reviewed
Jul 10, 2025
| <f:entry title="${%No delay provisioning}" field="noDelayProvisioning"> | ||
| <f:checkbox/> | ||
| </f:entry> | ||
| <f:entry title="${%JNLP Support}" field="jnlpSupport"> |
Member
There was a problem hiding this comment.
Please do not use the JNLP term in conjunction with Jenkins going forward; it has not actually used JNLP for years. Just refer to inbound agents (which may use either TCP or WebSocket transport).
jglick
reviewed
Jul 10, 2025
Comment on lines
320
to
332
| log.info("Adding JNLP Meta Data " + METADATA_CONTROLLER_URL + " = " + Jenkins.get().getRootUrl()); | ||
|
|
||
| items.add( | ||
| new Metadata.Items() | ||
| .setKey(METADATA_CONTROLLER_URL) | ||
| .setValue(Jenkins.get().getRootUrl())); | ||
|
|
||
| log.info("Adding JNLP Meta Data " + METADATA_JNLP_SECRET + " = " + JnlpAgentReceiver.SLAVE_SECRET.mac(instance.getName())); | ||
|
|
||
| items.add( | ||
| new Metadata.Items() | ||
| .setKey(METADATA_JNLP_SECRET) | ||
| .setValue(JnlpAgentReceiver.SLAVE_SECRET.mac(instance.getName()))); |
jglick
reviewed
Jul 10, 2025
Comment on lines
351
to
352
| JNLPLauncher jnlpLauncher = new JNLPLauncher(true); | ||
| jnlpLauncher.setWebSocket(true); |
Member
There was a problem hiding this comment.
Deprecated calls. Selection of transport and all other options is now left to the agent startup script.
jglick
reviewed
Jul 10, 2025
| --> | ||
| By default Jenkins use SSH to connect cloud nodes. | ||
| With this option enabled, a new node is created on GCP and will be connected using JNLP Protocol. | ||
| User needs to setup start-up script for Nodes to connect to master. |
Member
There was a problem hiding this comment.
You would need to document what environment variables (?) are exposed for the controller URL, agent name, and secret.
jglick
reviewed
Jul 14, 2025
|
|
||
| private transient volatile ComputeClient client; | ||
| private boolean noDelayProvisioning; | ||
| private boolean jnlpSupport; |
Member
There was a problem hiding this comment.
#312 (comment) similarly in the PR title, variable names, etc.
Author
|
Raised Fresh PR with latest Pull Refresh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.