OutboundAgent test utility#607
Conversation
| rule.jenkins.addNode(new DumbSlave( | ||
| name, | ||
| "/home/jenkins/agent", | ||
| new SSHLauncher(connectionDetails.host, connectionDetails.port, creds.getId()))); |
There was a problem hiding this comment.
No compelling reason to integrate with #570 for now, since the utility deliberately papers over details about how the agent is set up: it just needs to live “somewhere else”.
There was a problem hiding this comment.
Would it make sense to also enable authentication via username and password?
There was a problem hiding this comment.
It will be a different test, as one already exists. The point of this test is to use the official outboundAgent Docker image. We use an Ubuntu Docker image on purpose in the other tests.
There was a problem hiding this comment.
Would it make sense to also enable authentication via username and password?
No, because we do not care how the launcher works, just that it does. This is a test utility, not a test of the SSH launcher.
| package test.ssh_agent; | ||
|
|
||
| import hudson.model.Slave; | ||
| import org.junit.Rule; |
There was a problem hiding this comment.
Nit: Could it be JUnit 5? we recently migrate testcontainers test to JUnit 5
There was a problem hiding this comment.
Since the test uses RealJenkinsRule, this would require jenkinsci/jenkins-test-harness#988 or similar in order to work with JUnit 5
3 participants
No description provided.