Skip to content

Fix crashes when hook entities in "OnEntityCreated" #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensewe merged 2 commits into from
Feb 27, 2026
Merged

Fix crashes when hook entities in "OnEntityCreated" #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2d0940
Attempt to fix NULL net prop crashing
jensewe Feb 26, 2026
3f7acf5
Prevent use of uninitialized network prop
jensewe Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions extension/natives.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,40 @@ static bool IsPropValid(const SendProp *prop, PropType type)
return false;
}

static ServerClass* FindEdictServerClass(edict_t *edict)
{
// BUG: (See https://github.com/alliedmodders/hl2sdk/blob/72b927a0a4ee25c788148e6591ff859d1f81df65/game/server/baseentity.cpp#L403-L413)
// gEntList.AddNetworkableEntity is called right before edict()->m_pNetworkable is set
// which may lead to crashes if user establishes a hook in "OnEntityCreated".
//
// if (IServerNetworkable *pNetwork = edict->GetNetworkable())
// {
// return pNetwork->GetServerClass();
// }

if (IServerUnknown *pUnk = edict->GetUnknown())
{
if (IServerNetworkable *pNetwork = pUnk->GetNetworkable())
return pNetwork->GetServerClass();
}

if (const char* pClassname = gamehelpers->GetEntityClassname(edict))
{
return gamehelpers->FindServerClass(pClassname);
}

return nullptr;
}

void UTIL_FindSendProp(SendProp* &ret, IPluginContext *pContext, int index, const char* propname, bool checkType, PropType type, int element)
{
edict_t *edict = UTIL_EdictOfIndex(index);
if (!edict)
if (!edict || edict->IsFree())
return pContext->ReportError("Invalid edict index (%d)", index);

ServerClass *sc = edict->GetNetworkable()->GetServerClass();
ServerClass *sc = FindEdictServerClass(edict);
if (!sc)
return pContext->ReportError("Cannot find ServerClass for entity %d", index);
return pContext->ReportError("Cannot find ServerClass for edict (%d)", index);

sm_sendprop_info_t info;
gamehelpers->FindSendPropInfo(sc->GetName(), propname, &info);
Expand Down