Include optional parentId when creating issues#7
Open
larryhudson wants to merge 2 commits intojerhadf:mainfrom
Open
Include optional parentId when creating issues#7larryhudson wants to merge 2 commits intojerhadf:mainfrom
larryhudson wants to merge 2 commits intojerhadf:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 88f64c1 in 46 seconds
More details
- Looked at
92lines of code in1files - Skipped
0files when reviewing. - Skipped posting
9drafted comments based on config settings.
1. index.ts:24
- Draft comment:
Good addition of optional 'parentId' to CreateIssueArgs. Ensure this matches the API's expected type. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
2. index.ts:282
- Draft comment:
The createIssue method passes parentId correctly. Consider verifying that the API accepts an undefined parentId without issues. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
3. index.ts:529
- Draft comment:
The tool schema for 'linear_create_issue' now includes 'parentId' with a clear description. Nice work. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
4. index.ts:920
- Draft comment:
Minor formatting changes in template literals for listing issues. These changes improve consistency. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
5. index.ts:27
- Draft comment:
Added optional 'parentId' in CreateIssueArgs. Looks correct. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
6. index.ts:287
- Draft comment:
Pass 'parentId' in createIssue payload. Ensure API handles undefined gracefully. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
7. index.ts:522
- Draft comment:
Tool description and schema updated to include 'parentId' for sub-issues. Clear and consistent. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
8. index.ts:926
- Draft comment:
Input handler now converts 'parentId' to string if provided. Consistent with other fields. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
9. index.ts:973
- Draft comment:
Formatting cleanup in the issues mapping output; purely cosmetic with no functional impact. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_PNckGALwwQrN7VVA
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Owner
|
@larryhudson nice! I think this addition makes sense. could you resolve the conflicts and then I'll approve and merge? |
Author
|
Hey Jeremy, sorry for the delay. I've just resolved the conflicts, this should be good to go now 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for creating this MCP server! I'm trying it out using Cline in VS Code. I thought it would be useful to be able to specify a parent ID when creating a new issue, so that an existing issue can be broken up into smaller parts.
This PR adds the 'parentId' parameter to the 'create issue' tool and API calls. However, currently the 'parentId' needs to be a UUID, and I'm finding it a little difficult to use the 'search issues' tool - it's timing out for me. I'll try this out more later.
I tested this out by finding the UUID of an existing issue in the browser dev tools (looking at a GraphQL request) so at least including the 'parent ID' in the 'create issues' call is working.
Important
Add optional
parentIdtoCreateIssueArgsand updatecreateIssuemethod to support sub-issues in Linear.parentIdtoCreateIssueArgsinindex.tsfor creating sub-issues.createIssuemethod inLinearMCPClientto includeparentIdwhen creating issues.createIssueTooldescription and input schema to includeparentIdas an optional field for sub-issues.This description was created by
for 88f64c1. It will automatically update as commits are pushed.