This repository was archived by the owner on Mar 1, 2019. It is now read-only.
Open
Conversation
Author
|
Fix #3 |
carvind
reviewed
Aug 11, 2017
Dockerfile
Outdated
|
|
||
| RUN bin/plugin install lmenezes/elasticsearch-kopf/v2.1.2 | ||
| RUN bin/plugin install io.fabric8/elasticsearch-cloud-kubernetes/2.4.0_01 | ||
| RUN bin/elasticsearch-plugin install io.fabric8:elasticsearch-cloud-kubernetes:5.5.0 |
There was a problem hiding this comment.
can you upgrade to 5.5.1, now fabric8:elasticsearch-cloud-kubernetes plugin is on 5.5.1. see here
simonswine
reviewed
Aug 12, 2017
elasticsearch.yml
Outdated
| path: | ||
| plugins: /usr/share/elasticsearch/plugins | ||
| zen: | ||
| minimum_master_nodes: ${NUMBER_OF_MASTERS} |
Contributor
There was a problem hiding this comment.
Can we call that MINIMUM_MASTER_NODES ?
|
Please merge! |
Contributor
|
Some minor things to address, see my comments. Maybe you want to have a look?: @dippynark |
Author
|
I'll try to take time today to address the comments. |
|
Hello guys, any release soon? You're doing a good job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.