Add reference_options struct to contain options#14
Draft
sc68cal wants to merge 1 commit intojetzig-framework:mainfrom
Draft
Add reference_options struct to contain options#14sc68cal wants to merge 1 commit intojetzig-framework:mainfrom
sc68cal wants to merge 1 commit intojetzig-framework:mainfrom
Conversation
This allows the addition of ON DELETE CASCADE and other options Fixes jetzig-framework#13
Contributor
Author
|
Will add tests in next session |
Contributor
Author
|
Originally I wanted to change the pub const Reference = struct {
table: []const u8 = null,
column: []const u8 = null,
on_delete: ?DeleteOptions = null,
};But my zig-fu isn't strong enough to figure out how to turn it into a struct while still supporting the original array initialization syntax (if that's even possible in Zig), and I didn't want to make a breaking API change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the addition of ON DELETE CASCADE and other options
Fixes #13