Avoid crashing when OpenGL returns NULL from glMapBufferOES()#22
Open
rmgrimm wants to merge 5 commits intojharwig:masterfrom
Open
Avoid crashing when OpenGL returns NULL from glMapBufferOES()#22rmgrimm wants to merge 5 commits intojharwig:masterfrom
rmgrimm wants to merge 5 commits intojharwig:masterfrom
Conversation
|
I suppose this project is dead, but this is a very valuable PR that makes this pod work just dandy even on new hardware/OS a shame, since I think this is the best sig capture widget out there |
cosmith
added a commit
to dashdoc/react-native-signature-capture
that referenced
this pull request
Aug 22, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve issue #19.
Basically, the code is assuming that glMapBufferOES() will always return a valid pointer. The documentation for glMapBufferOES() states instead that null will be returned to signal an error. By ignoring the null case, the underlying OpenGL error results in a complete app crash when memcpy() tries to write data.
Following the OpenGL convention of ignoring commands if an error occurs, this code will ignore any errors that come out of OpenGL. I've dropped a few TODO comments where the code could be further improved. At least it shouldn't crash any longer.