You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is your reasoning for it? I kinda like being able to extend new
widgets via polymorphism. I guess my biggest concern would be that the push
class might become very large and bloated. I could be wrong but that is my
initial thoughts. What do you think?
@aaldrichhttps://github.com/aaldrich I'm thinking about simplifying
the push api to a single class Ducksboard::Slothttps://github.com/jhsu/ducksboard/blob/simple-slot-push/lib/ducksboard/slot.rband see
some exampleshttps://github.com/jhsu/ducksboard/tree/simple-slot-push#sending-data
What do you think?
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/7#issuecomment-15041587
.
I've started trying the Slot example just to see how I like it and having some issues. It seems like the post method inside the push api isn't being recognized on the class:
push.rb:45:in post': undefined methodpost' for Ducksboard::Slot:Class (NoMethodError)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added delta to the counter widget to support the new ducksboard changes