Skip to content

Conversation

@Aaditya-ops-cpu
Copy link

This PR addresses the feedback received regarding missing test coverage in the protoresolve package.

I have implemented the TODO items in protoresolve/resolvers_test.go. The tests now instantiate a real protoregistry.Files registry with standard test protos and verify that ResolverFromPool and ResolverFromPools correctly adapt the pool to satisfy the Resolver interface.
Verification Steps Performed

Following the recommendation to verify changes locally before pushing, I executed the following steps on an Ubuntu environment-

  1. Ran make checkgofmt (verified via gofmt -s -l .) to ensure no formatting issues remain.
  2. Ran make generate to ensure all imports and generated files are up to date.
  3. Ran make test (which executes go test -race ./...). All tests passed, specifically confirming protoresolve coverage.
    Verification Screenshot:
Screenshot from 2026-01-10 10-38-42

Also I attempted to run the full make ci suite. While the errcheck linter encountered a known tooling incompatibility the successful execution of make test and make checkgofmt confirms the logic and style are correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant