test(protoresolve): implement missing TestResolverFromPool and TestRe… #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the feedback received regarding missing test coverage in the protoresolve package.
I have implemented the TODO items in protoresolve/resolvers_test.go. The tests now instantiate a real protoregistry.Files registry with standard test protos and verify that ResolverFromPool and ResolverFromPools correctly adapt the pool to satisfy the Resolver interface.
Verification Steps Performed
Following the recommendation to verify changes locally before pushing, I executed the following steps on an Ubuntu environment-
Verification Screenshot:
Also I attempted to run the full make ci suite. While the errcheck linter encountered a known tooling incompatibility the successful execution of make test and make checkgofmt confirms the logic and style are correct.