Excluding hot pixels using percentile cut#11
Conversation
kacienk
left a comment
There was a problem hiding this comment.
remove dead files, besides LGTM
|
@kacienk if you expect some changes to be done it the repo, then it doesn't make sense to approve PR. Any furher commit will invalidate the approval. You can say LGTM in the text. |
- setErrorMessage inside convert() - remove relative path inside index.html
LGTM with changes means: "This PR needs some minor changes, that do not change logic in a fundamental manner. Once the changes are applied, then the PR is ready to merge." This way we avoid unnecessary re-review. I specifically described the changes that are needed and applying them would make this PR ready to merge. By the way, from my experience, changes do not change the approval status on Github. My approval status didn't change. |
You are correct, I though it's the other way around. This way your way of dealing with PR makes much more sense that what I suggest ! I am happy to learn that :) |
There was a problem hiding this comment.
Pull Request Overview
This PR sets up Tailwind CSS and TypeScript support, and implements a hot-pixel exclusion feature for image conversion using percentile cut in the WASM backend and corresponding UI controls.
- Configure project to use TypeScript and Tailwind CSS.
- Add
clip_pixels_with_percentilesin Rust WASM and new UI options for hot-pixel removal. - Refactor and remove legacy CSS and JSX files, migrate to Tailwind utility classes.
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| client/vite.config.ts | Added @ alias for source directory |
| client/tsconfig.json | Introduced strict TypeScript compiler settings |
| client/tailwind.config.js | Initialized Tailwind CSS content paths |
| client/src/components/images/ImageConverter.jsx | Added hot-pixel removal UI and percentile inputs |
| api/src/lib.rs | Implemented clip_pixels_with_percentiles WASM function |
Comments suppressed due to low confidence (2)
client/src/components/images/ImageConverter.jsx:42
- The variable name
previesAspectRatiosappears to be a typo and is unclear. Consider renaming topreviewAspectRatiofor clarity.
const [previesAspectRatios, setPreviesAspectRatios] = useState(16 / 10);
api/src/lib.rs:26
- The new
clip_pixels_with_percentilesfunction lacks dedicated unit tests. Adding tests for edge cases (e.g., empty data, extreme percentiles) would improve reliability.
pub fn clip_pixels_with_percentiles(
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>


Closes #9