Skip to content

Revert n_jobs parallel path to original implementation#2

Draft
Copilot wants to merge 4 commits intomainfrom
copilot/suggest-addition-to-repo
Draft

Revert n_jobs parallel path to original implementation#2
Copilot wants to merge 4 commits intomainfrom
copilot/suggest-addition-to-repo

Conversation

Copy link

Copilot AI commented Feb 20, 2026

The previous session's "fix" for TypeError: 'int' object is not iterable was unnecessary — the error was caused by an outdated version of the function in the caller's memory, not a code bug.

Changes

  • core.py: restored n_jobs parallel path to submit _evaluate_combination directly to ThreadPoolExecutor workers; removed the split raw-result collection + main-thread xarray wrapping, input validation, and os.cpu_count() or 1 guard
  • tests/test_xarray_sweep.py: removed test_n_jobs_minus_one_float_params, test_n_jobs_invalid_raises_value_error, and the now-unused import pytest

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: jkingslake <48723181+jkingslake@users.noreply.github.com>
Copilot AI changed the title [WIP] Suggest addition to the repository Add n_jobs parameter for thread-parallel parameter sweeps Feb 20, 2026
Copilot AI requested a review from jkingslake February 20, 2026 19:26
Co-authored-by: jkingslake <48723181+jkingslake@users.noreply.github.com>
Copilot AI changed the title Add n_jobs parameter for thread-parallel parameter sweeps Fix TypeError: 'int' object is not iterable when using n_jobs=-1 Feb 20, 2026
Co-authored-by: jkingslake <48723181+jkingslake@users.noreply.github.com>
Copilot AI changed the title Fix TypeError: 'int' object is not iterable when using n_jobs=-1 Revert n_jobs parallel path to original implementation Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants