Fix JS example to receive eventbus bridge messages#1
Open
Conversation
There appears to be an error in the code for the example to send and receive client side messages in Javascript over the eventbus bridge. As written, every message logged to the console is null. In order to make the example work I needed to add another parameter before the 'message' parameter so that it matches the source code for the onmessage function in vertx-eventbus.js on lines 131 and 141. There, the onmessage function has two calls which pass two arguments to a handler, and the arguments are '(null, json)'. I believe the first argument 'null' is to indicate an error has not occurred. When my client code matched the example in the Asciidoc and only had one argument, the json message was always arriving as null. My proposed fix to the example code allows the proper json message to be received by my client's handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to be an error in the code for the example to send and receive client side messages in Javascript over the eventbus bridge. As written, every message logged to the console is null. In order to make the example work I needed to add another parameter before the 'message' parameter so that it matches the source code for the onmessage function in vertx-eventbus.js on lines 131 and 141. There, the onmessage function has two calls which pass two arguments to a handler, and the arguments are '(null, json)'. I believe the first argument 'null' is to indicate an error has not occurred.
When my client code matched the example in the Asciidoc and only had one argument, the json message was always arriving as null. My proposed fix to the example code allows the proper json message to be received by my client's handler.