Skip to content

Fixes issues with null reference exceptions #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkuebler000 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes issues with null reference exceptions #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 31 additions & 13 deletions Src/Documenter/Mapping/RenderingMetaItemMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,22 +31,38 @@ public RenderingMetaItem Map(Item source)
{
if (source == null) return null;

return new RenderingMetaItem()
{
Id = source.ID.ToGuid(),
Path = source.Paths.GetPath(ItemPathType.Name),
Name = source.DisplayName,
Icon = string.Format(
System.Guid guid = source.ID.ToGuid();
string path = source.Paths.GetPath(ItemPathType.Name);
string name = source.DisplayName;
string icon = string.Format(
"{0}{1}{2}",
this._httpRequest.Url.GetComponents(UriComponents.SchemeAndServer, UriFormat.UriEscaped),
"/~/icon/",
source.Fields[FieldIDs.Icon].GetValueWithFallback("Software/16x16/element.png")),
ThumbnailImage = source.Fields[FieldIDs.Thumbnail].GetMediaUrlSafe(),
FullImage = this.MakeFullImage(source),
Description = source.Fields[Constants.Fields.LongDescription].Value,
DataSourceLocation = source.Fields[Constants.Fields.DataSourceLocation].Value,
DataSourceTemplate = this.FillRenderingDataSourceTemplate(source),
Type = source.TemplateName.Replace("Rendering", string.Empty).Replace("rendering", string.Empty)
source.Fields[FieldIDs.Icon].GetValueWithFallback("Software/16x16/element.png"));
string thumbnailImage = source.Fields[FieldIDs.Thumbnail].GetMediaUrlSafe();
string fullImage = this.MakeFullImage(source);

Field descriptionField = source.Fields[Constants.Fields.LongDescription];
string description = descriptionField == null ? string.Empty : descriptionField.Value;

Field dataSourceLocationField = source.Fields[Constants.Fields.DataSourceLocation];
string dataSourceLocation = dataSourceLocationField == null ? string.Empty : dataSourceLocationField.Value;

TemplateMetaItem templateMetaItem = this.FillRenderingDataSourceTemplate(source);
string type = source.TemplateName.Replace("Rendering", string.Empty).Replace("rendering", string.Empty);

return new RenderingMetaItem()
{
Id = guid,
Path = path,
Name = name,
Icon = icon,
ThumbnailImage = thumbnailImage,
FullImage = fullImage,
Description = description,
DataSourceLocation = dataSourceLocation,
DataSourceTemplate = templateMetaItem,
Type = type
};
}

Expand Down Expand Up @@ -77,6 +93,8 @@ private string MakeFullImage(Item item)

private TemplateMetaItem FillRenderingDataSourceTemplate(Item item)
{
var dataSourceTemplate = item.Fields[Constants.Fields.DataSourceTemplate];
if (dataSourceTemplate == null) return null;
var templateItem = this.Database.GetItem(item.Fields[Constants.Fields.DataSourceTemplate].Value);
if (templateItem == null)
{
Expand Down