feat: set default content type when processing body #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
httparty used to properly set multipart content type when dealing with files or multipart url bodies. There was no default for urlencoded. net-http 0.7.0 stops defaulting content type to x-www-form-urlencoded (net-http PR jnunemaker#207), thus httparty's default behavior of urlencoding needs to set content type. Content type does not get set when passed or when using custom query_string_normalizer. If you use custom query_string_normalizer, return content_type as a second argument.
zygzagZ
commented
Nov 6, 2025
| params.respond_to?(:to_hash) && (force_multipart || has_file?(params)) | ||
| end | ||
|
|
||
| def content_type |
Author
There was a problem hiding this comment.
it acts as a getter when set, and tries to calc when body is not yet evaluated.
Comment on lines
+19
to
+24
| if multipart? | ||
| @content_type = "multipart/form-data; boundary=#{boundary}" | ||
| generate_multipart | ||
| else | ||
| normalize_query_and_set_content_type(params) | ||
| end |
Author
There was a problem hiding this comment.
cus generate_multipiart sets @content_type, too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httparty does properly set multipart content type when dealing with files or multipart url bodies. There was no default for urlencoded.
net-http 0.7.0 stops defaulting content type to x-www-form-urlencoded (net-http PR #207, issue #205). HTTParty encodes body with urlencode by default, but does not set content-type. HTTParty's default behavior of urlencoding needs to set content type.
changes in this pr:
If you use custom query_string_normalizer, return content_type as a second argument or pass a
Content-Typeheader