Fixed various checkstyle errors. #78
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jody
reviewed
Mar 8, 2022
| @@ -1,5 +1,4 @@ | |||
| package metrocs; | |||
| import org.junit.jupiter.api.Test; | |||
Owner
There was a problem hiding this comment.
Note that the "error" is pointing out a shortcoming that needs to be addressed.
We need to consider why the error exists and what it is telling us.
What's actually needed here--to "fix" the "Checkstyle error"--is for there to be an actual test in the file.
Removing the import only "hides" the fact that the test class has no actual tests.
(This is similar to a "TODO:" error which is again indicating that something needs to be added rather than taken away.)
Owner
|
This PR doesn't specify which Issue is being addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixed trailing spaces in line 34 of HelloAnyone.java
-Fixed unused import in HelloANyoneText.java
-Fixed lack of trailing blank line at end of HelloWorld.java