fix: Handle multiline sql without spaces#215
Open
nossrannug wants to merge 1 commit intojoereynolds:typescriptfrom
Open
fix: Handle multiline sql without spaces#215nossrannug wants to merge 1 commit intojoereynolds:typescriptfrom
nossrannug wants to merge 1 commit intojoereynolds:typescriptfrom
Conversation
Owner
|
Hey @nossrannug thanks for this, I'll try and take a proper look at it in the week, looks good though! |
Owner
|
Hey again @nossrannug, I've just given this a go and there's a few test failures when running Let me know if you need any help with them. |
Owner
|
Also, would this solve this longstanding issue: ? |
Contributor
Author
|
Thanks, @joereynolds. |
When replacing multiline comment, it is now done with a space instead of nothing since this would be valid sql: ```sql SELECT pid FROM/*comment*/pg_stat_activity; ``` But replacing the comment with "" would make it incorrect. Also join the lines in query on getContent with a space to remove the need for spaces in the sql. Previously this sql: ```sql SELECT some_column FROM some_table; ``` would result in this error: `[error] column "some_columnfrom" does not exist` This PR fixes that.
nossrannug
force-pushed
the
query-content-spaces
branch
from
7abfaf3 to
45e465a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When replacing multiline comment, it is now done with a space instead of
nothing since this would be valid sql:
But replacing the comment with "" would make it incorrect.
Also join the lines in query on getContent with a space to remove the
need for spaces in the sql. Previously this sql:
would result in this error:
[error] column "some_columnfrom" does not existThis PR fixes that.