Update documentation to add missing references to the new database config option#289
Open
sepsol wants to merge 4 commits intojoereynolds:typescriptfrom
Open
Update documentation to add missing references to the new database config option#289sepsol wants to merge 4 commits intojoereynolds:typescriptfrom
database config option#289sepsol wants to merge 4 commits intojoereynolds:typescriptfrom
Conversation
…efault `database` value
Owner
|
Nice, there's a lot of changes here so I'll pull it down hopefully tomorrow and give it a look :) |
Author
Thanks! I think most of it is from the last commit where I built the markdown docs to HTML. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially created this PR because when I visited the deployed docs I didn't find any references to the new
databaseoption. But once I started to work on this PR, I noticed that many of the changes are already applied to the source files and are pending to be built and deployed. I added the bits that I thought were missing and then went ahead and built all of the docpages to help with pushing out the update ASAP.I was also wondering whether the
docsdirectory would need arequirements.txtfile to specify exactly what python packages are needed for the build process and aREADME.mdfile to more clearly state the commands that can be run to install those packages and run the build commands in theMakefile.I'm holding off on this last part but let me know if you want me to go ahead and apply those changes in this PR as well. Thanks!