Add support for PostgreSQL DO statements#290
Open
AlexVulaj wants to merge 1 commit intojoereynolds:typescriptfrom
Open
Add support for PostgreSQL DO statements#290AlexVulaj wants to merge 1 commit intojoereynolds:typescriptfrom
AlexVulaj wants to merge 1 commit intojoereynolds:typescriptfrom
Conversation
Adds parsing support for PostgreSQL DO anonymous code blocks to prevent "unable to lint" errors when processing migration files containing DO statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for PostgreSQL
DOstatements to the SQL linter. Previously, the linter would fail with "sql-lint was unable to lint the following query" errors when encounteringDOanonymous code blocks, which are commonly used in PostgreSQL migration files.Background
The linter was throwing parsing errors on valid PostgreSQL migration files containing DO statements like:
Changes
DOkeyword tosrc/syntax/keywords.tsDOstatement handler atsrc/lexer/statements/postgres/do.tsfollowing the same pattern as existing statement handlerssrc/lexer/statementFactory.tsto recognize and handle do statementssrc/barrel/statements.tsThe implementation follows the existing codebase patterns and conventions used by other PostgreSQL statement handlers like ALTER, CREATE, etc.
Test Plan
npm run buildDOstatements - no more "unable to lint" errorsDOas valid SQL syntaxImpact
This resolves parsing failures for PostgreSQL migration files that use
DOstatements, allowing the SQL linter to process these files without errors.