[kotlin2cpg] Use unique namespace fullNames for imports and for packages#5854
Merged
SuperUserDone merged 2 commits intomasterfrom Mar 5, 2026
Merged
[kotlin2cpg] Use unique namespace fullNames for imports and for packages#5854SuperUserDone merged 2 commits intomasterfrom
SuperUserDone merged 2 commits intomasterfrom
Conversation
ml86
reviewed
Mar 4, 2026
Contributor
There was a problem hiding this comment.
Name property of the namespace block for PackageFoo is wrong. The name property shall contain the fully qualified name com.test.PackageFoo.
Contributor
|
You are right, the imports are not represented correctly in the sense that an import statement should not result in the generation of a namespace block for the imported entity. |
Contributor
Author
|
Have resolved the naming issue and removed the redundant namespace block generation. |
ml86
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the policylinker issue, but not sure that imports are being represented correctly. From what I can tell javasrc does not create namespace blocks for imports.
https://github.com/joernio/joern/blob/master/joern-cli/frontends/javasrc2cpg/src/main/scala/io/joern/javasrc2cpg/astcreation/AstCreator.scala#L236-L259