Skip to content

remove jlhttp dependency (GPLv2 license)#5860

Open
mpollmeier wants to merge 1 commit intomasterfrom
michael/gpl-replace-jlhttp
Open

remove jlhttp dependency (GPLv2 license)#5860
mpollmeier wants to merge 1 commit intomasterfrom
michael/gpl-replace-jlhttp

Conversation

@mpollmeier
Copy link
Contributor

Having a GPLv2 license in the dependencies limits us downstream
and really isn't required for a simple http server. This replaces
it with HttpServer from the JDK.

jlhttp was initially introduced via #4892

Having a GPLv2 license in the dependencies limits us downstream
and really isn't required for a simple http server. This replaces
it with HttpServer from the JDK.
Copy link
Contributor

@max-leuthaeuser max-leuthaeuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test that with e.g., the CS integrations tests?
Looking at the failed tests here: looks like this is not thread-safe anymore?
server and frontendHTTPHandler were both objects.
(The frontends are mostly not thread-safe, that's why there must be only one request at the time per frontend)

@maltek
Copy link
Contributor

maltek commented Mar 6, 2026

(The frontends are mostly not thread-safe, that's why there must be only one request at the time per frontend)

That's supposed to be opt-in via the SingleThreadedFrontend trait, which forces a single-threaded thread pool.

@max-leuthaeuser
Copy link
Contributor

SingleThreadedFrontend

Ah yeah, totally forgot about that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants