Open
Conversation
Having a GPLv2 license in the dependencies limits us downstream and really isn't required for a simple http server. This replaces it with HttpServer from the JDK.
Contributor
There was a problem hiding this comment.
Did you test that with e.g., the CS integrations tests?
Looking at the failed tests here: looks like this is not thread-safe anymore?
server and frontendHTTPHandler were both objects.
(The frontends are mostly not thread-safe, that's why there must be only one request at the time per frontend)
max-leuthaeuser
approved these changes
Mar 6, 2026
Contributor
That's supposed to be opt-in via the |
Contributor
Ah yeah, totally forgot about that one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a GPLv2 license in the dependencies limits us downstream
and really isn't required for a simple http server. This replaces
it with HttpServer from the JDK.
jlhttp was initially introduced via #4892