Skip to content

Minor Bug Fix and WSL install Intructions#3

Open
orionnelson wants to merge 3 commits intojohan456789:masterfrom
orionnelson:minor-bug-fix
Open

Minor Bug Fix and WSL install Intructions#3
orionnelson wants to merge 3 commits intojohan456789:masterfrom
orionnelson:minor-bug-fix

Conversation

@orionnelson
Copy link

@orionnelson orionnelson commented Oct 6, 2023

  • Fixed WSL windows Bug which causes issues in either WSL or Cgywin.
  • Fixed unused basename argument for output pdf name.
  • Added install instructions for Windows and WSL due to different tessaract install name.
  • Added requirements.txt

@johan456789
Copy link
Owner

Thank you for the pull request. I will find time to test your code.

@orionnelson
Copy link
Author

Thank you for the pull request. I will find time to test your code.
No problem. Let me know if I need to do any other changes I have tested on windows 10 wsl. However the regex bug was in cgywin or some other Unix emulator.

@orionnelson
Copy link
Author

I created an small workflow for testing and got testing for OSx and Ubuntu working. I just need to change the alias for python3 in OSx to be python. And some better ui for merge requests. orionnelson#5. Choco only works 25% of the time on GitHub for some reason.

@johan456789
Copy link
Owner

Hi, thanks again for the PR. I took a look and it contains 2 changes:

  1. refactoring (moving code into separate functions) & fixes
  2. adding tests and github workflow

Can you split them into 2 PRs please? It would be much easier to review. Also, the PR currently contains slide_extractor.py and slide-extractor.py. I believe this is a mistake and slide-extractor.py should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants