-
-
Notifications
You must be signed in to change notification settings - Fork 14
Removed text from desktop #189 #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Lavina-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issue #189 by removing the 'Showing X of Y developers' text from the desktop interface. The change involves a comprehensive cleanup across HTML, JavaScript, and CSS files to eliminate the display of this specific UI element and all its supporting code, resulting in a cleaner and more focused user experience on desktop. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes the desktop-specific results information UI, as intended. The changes in the HTML, CSS, and JavaScript files are mostly correct and follow the PR's objective. However, I've identified a regression in docs/script.js where the loading state is no longer displayed, which will impact user experience. I've also noted a minor formatting issue in docs/styles.css. Please review the suggested changes to address these issues.
| const loadingState = document.getElementById('loadingState'); | ||
| const loadingStateDesktop = document.getElementById('loadingStateDesktop'); | ||
| const resultsInfo = document.getElementById('resultsInfo'); | ||
| const resultsInfoDesktop = document.getElementById('resultsInfoDesktop'); | ||
|
|
||
| [loadingState, loadingStateDesktop].forEach( | ||
| (el) => el && (el.style.display = 'flex'), | ||
| ); | ||
|
|
||
| if (resultsInfo) resultsInfo.style.display = 'none'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loading spinner is no longer being displayed because the logic to show loadingState was removed during refactoring. This will prevent users from seeing a loading indicator during data operations. You should restore the logic to display the loadingState element.
| const loadingState = document.getElementById('loadingState'); | |
| const loadingStateDesktop = document.getElementById('loadingStateDesktop'); | |
| const resultsInfo = document.getElementById('resultsInfo'); | |
| const resultsInfoDesktop = document.getElementById('resultsInfoDesktop'); | |
| [loadingState, loadingStateDesktop].forEach( | |
| (el) => el && (el.style.display = 'flex'), | |
| ); | |
| if (resultsInfo) resultsInfo.style.display = 'none'; | |
| const loadingState = document.getElementById('loadingState'); | |
| const resultsInfo = document.getElementById('resultsInfo'); | |
| if (loadingState) loadingState.style.display = 'flex'; | |
| if (resultsInfo) resultsInfo.style.display = 'none'; |
|
|
||
| #loadingState, | ||
| #loadingStateDesktop { | ||
| #loadingState{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR fixes #189
As requested, I have removed "Showing X of Y developers" text from top of the page in desktop.
Changes included
Screenshot is attached