Skip to content

Conversation

@Lavina-11
Copy link

This PR fixes #189

As requested, I have removed "Showing X of Y developers" text from top of the page in desktop.

Changes included

  • Removed the desktop-specific results info UI from the HTML layout.
  • Updated the corresponding JavaScript logic to ensure no references remain to the removed desktop elements
  • Cleaned up corresponding styling part which was not required
  • All pre - commits checks passed successfully

Screenshot is attached

Screenshot 2025-12-26 234155

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Lavina-11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #189 by removing the 'Showing X of Y developers' text from the desktop interface. The change involves a comprehensive cleanup across HTML, JavaScript, and CSS files to eliminate the display of this specific UI element and all its supporting code, resulting in a cleaner and more focused user experience on desktop.

Highlights

  • UI Element Removal: The 'Showing X of Y developers' text, along with its associated loading and results information, has been completely removed from the desktop view of the application.
  • JavaScript Logic Cleanup: All JavaScript references and manipulation logic related to the removed desktop UI elements (e.g., totalCountDesktop, visibleCountDesktop, resultsFoundDesktop, loadingStateDesktop) have been deleted.
  • CSS Styling Cleanup: Unused CSS rules and selectors specifically targeting the removed desktop results information and loading states have been purged from the stylesheet.
  • HTML Structure Simplification: The HTML layout has been streamlined by removing the div elements that previously housed the desktop-specific results and loading indicators.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@deepsource-io
Copy link
Contributor

deepsource-io bot commented Dec 26, 2025

Here's the code health analysis summary for commits e06262c..a9f7c0e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the desktop-specific results information UI, as intended. The changes in the HTML, CSS, and JavaScript files are mostly correct and follow the PR's objective. However, I've identified a regression in docs/script.js where the loading state is no longer displayed, which will impact user experience. I've also noted a minor formatting issue in docs/styles.css. Please review the suggested changes to address these issues.

Comment on lines 1062 to 1066
const loadingState = document.getElementById('loadingState');
const loadingStateDesktop = document.getElementById('loadingStateDesktop');
const resultsInfo = document.getElementById('resultsInfo');
const resultsInfoDesktop = document.getElementById('resultsInfoDesktop');

[loadingState, loadingStateDesktop].forEach(
(el) => el && (el.style.display = 'flex'),
);

if (resultsInfo) resultsInfo.style.display = 'none';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The loading spinner is no longer being displayed because the logic to show loadingState was removed during refactoring. This will prevent users from seeing a loading indicator during data operations. You should restore the logic to display the loadingState element.

Suggested change
const loadingState = document.getElementById('loadingState');
const loadingStateDesktop = document.getElementById('loadingStateDesktop');
const resultsInfo = document.getElementById('resultsInfo');
const resultsInfoDesktop = document.getElementById('resultsInfoDesktop');
[loadingState, loadingStateDesktop].forEach(
(el) => el && (el.style.display = 'flex'),
);
if (resultsInfo) resultsInfo.style.display = 'none';
const loadingState = document.getElementById('loadingState');
const resultsInfo = document.getElementById('resultsInfo');
if (loadingState) loadingState.style.display = 'flex';
if (resultsInfo) resultsInfo.style.display = 'none';


#loadingState,
#loadingStateDesktop {
#loadingState{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and to adhere to common CSS coding conventions, please add a space between the selector #loadingState and the opening brace {.

Suggested change
#loadingState{
#loadingState {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Super easy task: we need to remove Showing X of Y developers from top of the page in desktop

1 participant