Fix CI: clippy needless_borrows and rustfmt formatting#8
Draft
Copilot wants to merge 2 commits intoclaude/vault-migration-security-VShCSfrom
Draft
Fix CI: clippy needless_borrows and rustfmt formatting#8Copilot wants to merge 2 commits intoclaude/vault-migration-security-VShCSfrom
Copilot wants to merge 2 commits intoclaude/vault-migration-security-VShCSfrom
Conversation
Co-authored-by: johnzfitch <10013448+johnzfitch@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add vault migration engine for automatic version upgrades
Fix CI: clippy needless_borrows and rustfmt formatting
Mar 7, 2026
Owner
|
@claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI jobs were failing in the vault migration PR:
clippy(9needless_borrows_for_generic_argserrors) andfmt(formatting drift inmigration.rsandops.rs).Changes
src/vault/migration.rs: Removed redundant&borrows inSTANDARD.encode(...)calls inside test helpers —encodeacceptsimpl AsRef<[u8]>, so passing owned arrays directly (e.g.,nonce,sn) is sufficientsrc/vault/migration.rs+src/vault/ops.rs: Appliedcargo fmtto resolve line-length and indentation issues flagged by the format job🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.