Add ability to run validations asynchronously#227
Open
makivlach wants to merge 1 commit intojoiful-ts:masterfrom
Open
Add ability to run validations asynchronously#227makivlach wants to merge 1 commit intojoiful-ts:masterfrom
makivlach wants to merge 1 commit intojoiful-ts:masterfrom
Conversation
Member
|
Thanks for tackling the feature request! We can't accept untested changes. Tests help document the expected/desired behaviour. Once you, or someone else, contributes tests, we can review and merge these changes. The readme will also need to be updated, to document the feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made this pull request in regards to this issue: #178.
I didn't have time to write tests, though. Please, someone, take this on.