Skip to content

Fix resource leak by deferring rows.Close() in handleMapping. #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonbodner merged 1 commit into from
Feb 12, 2026
Merged

Fix resource leak by deferring rows.Close() in handleMapping. #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ func makeQuerierReturnVals(ctx context.Context, funcType reflect.Type, builder m
}

func handleMapping(ctx context.Context, sType reflect.Type, rows *sql.Rows, builder mapper.Builder) (interface{}, error) {
defer rows.Close()
var val interface{}
var err error
if sType.Kind() == reflect.Slice {
Expand All @@ -327,7 +328,6 @@ func handleMapping(ctx context.Context, sType reflect.Type, rows *sql.Rows, buil
} else {
val, err = mapRows(ctx, rows, builder)
}
rows.Close()
return val, err
}

Expand Down
Loading