Test and fix critical bugs #66
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests cover: nil rows panic in handleMapping (#18), nil map value panic in setupDynamicQueries (#19), fromPtr(nil) panic (#20), unbounded slice index panic in Extract (#21), and Build() setting embedded struct fields despite errors (#22). All panic-related tests currently fail, confirming the bugs exist. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bug fixes: - Replace unsafe.Pointer(nil) with reflect.Zero(reflect.PointerTo()) (#17/#8) - Add nil guard before defer rows.Close() in handleMapping (#18) - Handle nil types from reflect.TypeOf(nil) in downstream code (#19) - Add nil guard in fromPtr and fromPtrType (#20) - Add bounds checking for slice index in Extract (#21) - Only set embedded struct field in Build() when inner Build succeeds (#22) Modernization: - Use reflect.TypeFor[] instead of reflect.TypeOf((*T)(nil)).Elem() - Refactor if/else-if chain to switch in MakeBuilder - Use reflect.Pointer instead of reflect.Ptr - Move errType to package-level var - Update MODERNIZATION.md to mark completed items Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.