Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for the Bun package manager by letting the which() helper detect .bunx executables on Windows and streamlining the prettier lookup logic.
- Extend
which()to include the.bunxextension for Bun executables on Windows - Simplify
make_local_prettier_path()by removing redundant.cmdhandling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| jsprettier/util.py | Append .bunx to PATHEXT so Windows which() can find Bun binaries |
| jsprettier/sthelper.py | Remove explicit .cmd extension handling and rely on which() |
Comments suppressed due to low confidence (3)
jsprettier/util.py:308
- Add unit tests to ensure
which()correctly resolves executables with the.bunxextension on Windows environments.
pathext.append(".bunx") # add bunx extension for bun package manager
jsprettier/sthelper.py:196
- [nitpick] Update the surrounding comment to reflect that
.cmdextension handling was removed and extension resolution is now delegated towhich().
# 4. check globally install prettier
jsprettier/sthelper.py:197
- The import for
ensure_file_has_extis no longer used after removing the Windows.cmdlogic—consider cleaning up the unused import.
return which('prettier')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for Bun package manager.
Closes #305