Type predicate for easier type checking#28
Open
PumpedSardines wants to merge 1 commit intojonschlinkert:masterfrom
PumpedSardines:master
Open
Type predicate for easier type checking#28PumpedSardines wants to merge 1 commit intojonschlinkert:masterfrom PumpedSardines:master
PumpedSardines wants to merge 1 commit intojonschlinkert:masterfrom
PumpedSardines:master
Conversation
|
The point of this function is to return true or false if the value passed in is an object, and it does. I don't understand your issue. |
Author
|
@windusayles Take this following example if "isObject" returns a bool const myVariable: unknown = ({ foo: "bar" }) as any;
if(isObject(myVariable)) {
// TypeScript still sees myVariable as unknown in this scope
}And this is an example if isObject returns const myVariable: unknown = ({ foo: "bar" }) as any;
if(isObject(myVariable)) {
// TypeScript now sees myVariable as { [key: string]: unknown }
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to address my complaint in issue #27. Instead of the return type being true or false, the function should return if the value is a object or not.