[4.x] Revert AbstractWebApplication magic getter removal #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bembelimen
approved these changes
Aug 28, 2025
|
Better to do it like joomla/joomla-cms#46000. |
richard67
added a commit
to richard67/application
that referenced
this pull request
Aug 28, 2025
…amework#142)" This reverts commit 8d85ced.
bembelimen
pushed a commit
that referenced
this pull request
Aug 28, 2025
|
Can we revert this as joomla/joomla-cms#46000 got merged. So the framework is clean and we have some more time in the CMS to phase out direct input access. |
Contributor
Author
|
|
ah sorry, missed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for CMS issues joomla/joomla-cms#45996 and joomla/joomla-cms#45946
Summary of Changes
This pull request (PR) partially reverts PR #137 by adding back the magic getter method for the inpout property of the AbstractWebApplication.
Testing Instructions
See CMS issues joomla/joomla-cms#45996 and joomla/joomla-cms#45946 .
Documentation Changes Required
None besides the one changed by this PR.